Moves the top panel to the secondary monitor if the primary is in fullscreen
Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.
Version | Status |
---|---|
13 | Active |
12 | Inactive |
11 | Inactive |
10 | Rejected |
9 | Active |
8 | Inactive |
7 | Inactive |
6 | Inactive |
5 | Inactive |
4 | Active |
3 | Inactive |
2 | Inactive |
1 | Inactive |
Why eval? (line 93 and 109 extension.js) It's not a good practice to use eval like that.
I know, but I need to convert a patched function string to the function back. The second way to do the same - copy a whole code of the original function to my extension, correct the function and assign the corrected back. But this way I need to track changes in this function every update of gnome-shell , so it might break something.
Approved. We had a discussion about this extension on GNOME Matrix channel and we came to conclusion that we can approve this one since we don't have a rule against eval. As suggested on GNOME Matrix channel, `new Function()` is safer and you should take that approach if you can. I also suggest to re-implement the function instead of doing replace. Your can read our discussion on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
* edit > As suggested on GNOME Matrix channel, `new Function()` is safer and you should take that approach if you can. Is not related to this review.