Fuzzy application search results for Gnome Search
Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.
Version | Status |
---|---|
25 | Active |
24 | Active |
23 | Active |
22 | Rejected |
21 | Rejected |
20 | Active |
19 | Active |
18 | Active |
17 | Inactive |
16 | Active |
15 | Active |
14 | Inactive |
13 | Active |
12 | Active |
11 | Active |
10 | Active |
9 | Rejected |
8 | Rejected |
7 | Rejected |
6 | Rejected |
5 | Rejected |
4 | Rejected |
3 | Active |
2 | Active |
1 | Active |
Hi, I hope I've now addressed the biggest issues (you were right, by the way, I should've done file handling in async JS and not in a separate process). The one thing I have not changed is that I still use a lot of small JSONs instead of one large database. This is, honestly, mainly because I don't wanna find a database library that works in GJS. In my defence, AFAIK Whoosh for python ( https://github.com/mchaput/whoosh ) does similarly file-based non-DB indexing.
This looks good in principle, although I think it's bit concerning that none of your Promises have any error handling. When wrapping async functions from GIO, it's necessary to catch errors so they can be propagated: ```js new Promise((resolve, reject) => { file.delete_async(GLib.PRIORITY_DEFAULT, null, (file_, res) => { // If an error occurs, it will happen in the scope of this callback, not the Promise. try { resolve(file.delete_finish(res)); } catch (e) { // You don't have to reject() errors, but you do have to catch them. So you could // call resolve() here. reject(e); } }); }); ``` My bullet points for this submission are: * In your code, any failed Promise will neither resolve nor reject; in other words it will never settle and you will leak memory for each failed operation. * You should not call `GLib.Checksum.free()`, but if it caused problems you would have noticed. Aside from that, this all looks good. If you add error handling to you Promises, I will be happy to approve your extension :)
Yeah, honestly, in retrospect, I should've anticipated that. I'll change those, thank you!