Review "Nothing to say" version 11 - GNOME Shell Extensions

Review of "Nothing to say" version 11

Details Page Preview

Nothing to say

by wbolster

Unmute the microphone only when you have something to say.

Extension Homepage: https://github.com/wbolster/nothing-to-say

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
21	Active
20	Active
19	Rejected
18	Active
17	Active
16	Active
15	Active
14	Active
13	Active
12	Rejected
11	Rejected
10	Active
9	Active
8	Active
7	Active
6	Active
5	Active
4	Active
3	Active
2	Active
1	Active

Previous Reviews on this Version

JustPerfection waiting for author February 16, 2022

Where do you remove `mute_timeout_id` on disable()?

wbolster posted a review February 16, 2022

it's not added in `enable()`. note that `activate()` if when the microphone activates, not when the extension starts.

JustPerfection rejected February 16, 2022

I understand but that callback can get triggered after the extension is disabled. 1. Please remove `mute_timeout_id` on disable: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 2. Move line 194 to enable and null that out in disable: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions