Review of "Obmin" version 24

Details Page Preview

One-Click File Sharing for your network. Obmin is lightweight HTTP(S) File Server for GNU/Linux systems. Features: ⚫ Easy installation. ⚫ Easy setup just choose file(s) locations and tune Obmin on. ⚫ Doesn't require ROOT privileges. ⚫ Doesn't require any special client side installation. ⚫ HTTP transfer protocol available everywhere Linux, OSX, Windows, Android, iOS so. ⚫ More ... For more information and how-to see README.md

Extension Homepage
https://obmin.github.io

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
25 Active
24 Rejected
23 Active
22 Active
21 Active
20 Active
19 Active
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
10 Active
9 Active
8 Active
7 Active
6 Rejected
5 Rejected
4 Rejected
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. Rejected because timeouts in line 111 and 392 should be removed on disable: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 2. You can use `ps -A | grep obmin-server` in line 256 instead. If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
konkor posted a review
1. it's removing update_event ID in the remove_events function in line 228 on disable. 2. I cant remove 392 it should be executed to remove a text message in the middle of the screen of GNOME Shell. 3. GLib.spawn_command_line_sync cant execute pipelines as I remember. Thank you for such attention!
JustPerfection posted a review
2. Still should be removed because we don't want the callback get triggered after disable. 3. Please read this: https://gjs.guide/guides/gio/subprocesses.html