Review of "Harddisk LED" version 26

Details Page Preview

Show harddisk activity (IO speed read/write and LED). Click to change led size

Extension Homepage
https://github.com/biji/harddiskled

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Line 33 to 86 (extension.js) should be moved to enable. also null them out in disable. https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 2. Use initTranslations() and getSettings() from ExtensionUtils instead of creating your own custom functions (remove convenience.js after that): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js Supported on 3.32 and higher. 3. You cannot have `shell-version`s higher than current developing GNOME Shell version in metadata.json: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions