Review of "Toggle Dock" version 1

Details Page Preview

Adds a button to top panel to switch Dash to Dock mode between "always visible" and "autohide". *Does not work with all dock extensions.* Works with the following extensions: -Dash to Dock -Ubuntu Dock -Dash to Dock for COSMIC

Extension Homepage
https://github.com/Kavoyaa/dash-to-dock-toggle

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
5 Active
4 Inactive
3 Inactive
2 Inactive
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. You cannot use spawn command in global scope which is the same as init (line 35 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 2. Don't use spawn command for changing gsettings value (line 49 and 52 extension.js). You can use Gio instead: ```js const Gio = imports.gi.Gio; let settings = new Gio.Settings({ schema: 'org.gnome.shell.extensions.dash-to-dock' }); settings.set_boolean('dock-fixed', true); // set the value to true let value = settings.get_boolean('dock-fixed'); // get the value ``` 3. Remove stylesheet.css since you are not using it: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions