Review of "Monitor Status Indicator" version 2

Details Page Preview

Add a systems status menu for rotating monitors (overrides what is currently provided by gnome-settings-daemon)

Extension Homepage
http://git.gnome.org/gnome-shell-extensions

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
21 Active
20 Active
19 Active
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Rejected
1 Active

Previous Reviews on this Version

Jasper St. Pierre posted a review
This is a mass review for everything with your new "convenience module". Yes, I know this extension doesn't use gsettings: Can we be sure that users will have GLib 2.30.2? You should probably do something if Gio.SettingsSchemaSource doesn't exist.
gcampax posted a review
I think that the requirement is fine, because: 1) soon these extensions will depend on gnome-shell version 3.3.2 (or 3.3.3), which will prevent installation on older system lacking the necessary glib. Some of them already do, in the sense that they don't work with 3.2.1 as tagged, and require master. 2) extensions.gnome.org is not public yet; by the time it is released, I expect at least 3.3.3 to be out, if not 3.3.4. 3) just creating the GSettings object would abort the system if the schema is not installed (which is the case, if the extension is installed from e.g.o); at least, with this we get a TypeError at init() and move on In any case, it would be interesting to have multiple parallel versions of each extension available, and automatically pick the newer which is also compatible with installed shell (like addons.mozilla.org does with Firefox). Finally, a two small comments about the review interface: - when comparing files, you should show only the actual changes with some context, not the whole files - binary files should not be shown inline as text; offer to download them instead
Jasper St. Pierre posted a review
The current ETA for EGO is less than a week, that is, November 24th. The multiple parallel versions is something I've been planning to do. The hard part is that we need to do some funky JS to do it, since the server doesn't know the user's shell version unless the JS tells them. I went ahead and made the two changes you suggested to the review interface. I'd feel more comfortable accepting this extension if you upped the GNOME Shell version numbers to be the latest unstable instead of GNOME 3.2. Also, you don't need to have both "3.2" and "3.2.1" for a version.