Review of "wattmeter-forked" version 1

Details Page Preview

A fork of the Wattmeter extension by blackBriar, compatible with gnome 40. Original version: https://extensions.gnome.org/extension/1867/wattmeter/

Extension Homepage
https://github.com/clementherve/wattmeter-forked

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version Status
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Timeout in line 46 (extension.js) should be removed on disable: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 2. Where is `this.interval` in line 126 (extension.js)? You mean `this._measureTimeout`? 3. Please also mention in description (metadata.json) that your extension is a forked version of `wattmeter`. original: https://extensions.gnome.org/extension/1867/wattmeter/ 4. It's better to use another name to be more distinguishable from the original: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed 5. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
clementherve posted a review
Please discard Version 2, I could not see the rejection message and I missed a few things. Thank you for your review!