Review of "Volume Booster" version 1

Details Page Preview

Boost Volume above 150%


No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

Tapan Rachchh posted a review
JustPerfection rejected
1. You should remove the volumeBooster from panel on disable. 2. Also destroy and null out `volumeBooster` in disable. 3. don't hold the `Extension` instance as global (extension.js line 38). Just return it. 4. What does line 102 to 111 is doing in booster.js? 5. Use gjs instead of spawn command for line 90-99 in booster.js. Maybe you can do it with mixercontrol: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/6618dbb1308b446fb4575ef45b1de31ef3ae4497/js/ui/status/volume.js#L22 https://gjs-docs.gnome.org/gvc10~1.0_api-mixercontrol/ 6. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions