Review of "gnomehub" version 1

Details Page Preview

An all in one extension which catagorizes notifications and displays system information

Extension Homepage
https://gnome-hub.github.io/

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
6 Active
5 Active
4 Inactive
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. What is the use case for `session-modes`? If you don't have any use case for that, remove `session-modes` key from metadata.json: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#session-modes 2. Remove `41.alpha` and only use "41". "41" means all minor versions of 41 is supported. 3. Remove `extension.js.old`: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files 4. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html 5. Log should only be available in debug mode: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#no-excessive-logging 6. Why do you send `Stackoverflow/1.0` in line 345 and 364 (extension.js)? 7. Why `_getWeatherUri()` is unused but implemented? 8. Where `originalCountUpdated` is going back to original place (MessageTray.Source.countUpdated)? 9. In disable(), before line 406, you should use `this.indicator.destroy()`. Because you need to trigger onDestroy() first and without that the timeout will remain active. 10. `Extension._refresh_monitor()` not getting used. Why? If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
Colton222 posted a review
1. removed session modes 2. removed 41.alpha 3. removed old file 4. corrected, thank you for the helpful links :) 5. removed unnecessary log statements 6. needed to send a header to get the response- changed to gnomehub instead of stackoverflow 7. removed, may be readded in future version 8. in disable now 9. fixed 10. opted for a different method and this was useless now so removed