Review of "Legacy (GTK3) Theme Scheme Auto Switcher" version 1

Details Page Preview

Change the GTK3 theme to light/dark variant based on the system color scheme

Extension Homepage
https://github.com/mukul29/legacy-theme-auto-switcher-gnome-extension

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
9 Active
8 Active
7 Active
6 Rejected
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `stylesheet.css` since you are not using it: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files 2. You cannot create objects in the constructor object that init returns (line 28 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization Move that line to enable and null it out in `disable()`. 3. Why don't you use `changed` from gsettings instead of dbus? ```js let id = this.schema.connect('changed:gtk-theme', () => { let value = this.schema.get_string('gtk-theme'); // ... }); ``` If you want to do it this way, you need to disconnect the id in disable: ```js this.schema.disconnect(id); ``` https://gjs.guide/extensions/review-guidelines/review-guidelines.html#disconnect-all-signals 4. If this package has GitHub or GitLab, please include it in url (metadata.json): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions