Review of "Files Menu" version 15

Details Page Preview

Quickly navigate your file system and open files through a menu.

Extension Homepage
https://gitlab.com/bertoldia/files-menu

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Rejected
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Rejected
3 Rejected
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection waiting for author
1. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html 2. Remove .po and .pot files: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files 3. Use `ExtensionUtils.initTranslations()` instead of line 30 (extension.js): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js 4. Also null out `indicator` in `disable()`. 5. Remove unnecessary `Lang` import (line 23 menuItems.js). 6. UUID is not well formed: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed I should discuss this one with other team members though. Maybe we can approve it, because the old versions are approved like this. Please wait for the final review until we discuss this one on GNOME Matrix channel. Thanks! If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
bertoldia posted a review
Thanks for the feedback JustPerfection!!! Will look at all comments.
JustPerfection waiting for author
Thansk!
JustPerfection active
Approved but fix 1 to 5 for the next version.