Review of "Trash" version 19

Details Page Preview

A Trash button for the GNOME shell panel

Extension Homepage
https://gitlab.com/bertoldia/gnome-shell-trash-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
23 Active
22 Active
21 Active
20 Active
19 Active
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection waiting for author
1. Remove .po and .pot files: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files 2. Use `ExtensionUtils.initTranslations()` instead of line 242 (extension.js): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js 3. Null out `indicator` in `disable()`. This extension has the same UUID issue as other extension: https://extensions.gnome.org/review/31611 I'll move this one to the GNOME Matrix channel too.
JustPerfection active
Approved but fix 1 to 3 for the next version.