Review of "Force Quit" version 23

Details Page Preview

Adds a force quit button. Click the toolbar button, then choose the window you want to force quit. On accidental click, right click anywhere or press [Esc] to abort the kill.

Extension Homepage
https://github.com/meghprkh/force-quit/

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Also null out `button` in disable (extension.js). 2. You should disconnect the signal on disable (line 104 selection.js)
megh posted a review
1. Creating a new patch 2. Line 202 in selection.js calls this.disconnectAll. That should work? I dont know the API exactly but since it is copied from EasyScreenCast I assumed it works
JustPerfection posted a review
You should disconnect the signal by signal id.
megh posted a review
Thanks I understood, as this is a signal id from Main.session and not in the current object. However since I want to keep as little edits from upstream easyscreencast, I just commented it out. I will also submit an upstream PR to review the changes, which I would merge later https://github.com/EasyScreenCast/EasyScreenCast/pull/331
JustPerfection posted a review
Great!