Review of "Force Quit" version 23

Details Page Preview

Adds a force quit button. On accidental click, right click or press [ESC] to undo. Customize position by tweaking line 50 of extension.js

Extension Homepage
https://github.com/meghprkh/force-quit/

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
34 Active
33 Active
32 Active
31 Active
30 Inactive
29 Rejected
28 Active
27 Active
26 Active
25 Active
24 Rejected
23 Rejected
22 Active
21 Active
20 Active
19 Active
18 Active
17 Inactive
16 Inactive
15 Active
14 Rejected
13 Active
12 Active
11 Active
10 Inactive
9 Inactive
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Also null out `button` in disable (extension.js). 2. You should disconnect the signal on disable (line 104 selection.js)
megh posted a review
1. Creating a new patch 2. Line 202 in selection.js calls this.disconnectAll. That should work? I dont know the API exactly but since it is copied from EasyScreenCast I assumed it works
JustPerfection posted a review
You should disconnect the signal by signal id.
megh posted a review
Thanks I understood, as this is a signal id from Main.session and not in the current object. However since I want to keep as little edits from upstream easyscreencast, I just commented it out. I will also submit an upstream PR to review the changes, which I would merge later https://github.com/EasyScreenCast/EasyScreenCast/pull/331
JustPerfection posted a review
Great!