Review of "Order Gnome Shell extensions" version 7

Details Page Preview

Orders icons from extensions in the top bar

Extension Homepage
https://github.com/andia89/order-icons

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
22 Active
21 Active
20 Active
19 Active
18 Active
17 Active
16 Rejected
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Rejected
7 Rejected
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. You cannot create objects in global scope (line 12 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization Move line 12-15 to enable and null them out in disable. 2. Also do this on disable: ```js settingIds = null; ``` 3. Remove the timeout in disable (line 156 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 4. Remove `stylesheet.css`: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files 5. Use initTranslations() and getSettings() from ExtensionUtils instead of creating your own custom functions (remove convenience.js after that): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js It is supported on 3.36 and higher. So remove 3.x version from metadata.json. 6. Why do you want to also have prefs as stand alone gtk app? (line 7-19, 406-422 in prefs.js) If you want to open prefs from extension.js, just call `ExtensionUtils.openPrefs()` (supported on 3.36 and higher). 7. Multi versioning is supported here. So don't worry about dropping 3.x from your extension. If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
JustPerfection posted a review
btw, you forgot to include compiled schema file.