Review of "All IP Addresses" version 4

Details Page Preview

Show IP addresses for LAN, WAN IPv6 and VPN in the GNOME panel. Click on the address to cycle trough different interfaces.

Extension Homepage
https://github.com/phavekes/gnome-extension-all-ip-addresses

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
13 Rejected
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Inactive
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

phavekes auto- active
JustPerfection posted a review
Please read the version 3 review. Also remove logs and null out `_indicator` in disable.
phavekes posted a review
Thank you for the review. What do you mean by "null out `_indicator`"?
JustPerfection posted a review
I mean: ```js function disable() { _indicator.stop(); _indicator.destroy(); _indicator = null; // < this line } ``` That's because we don't want to hold `_indicator` in global scope after disable.
phavekes posted a review
I've made the changes in a new version
JustPerfection posted a review
Thanks! Please also fix the issues from the version 3 review.