Review of "Timezones extension" version 3

Details Page Preview

Show multiple clocks in the panel. For those who need more than one additional clock.

Extension Homepage
https://github.com/Masquerade-Circus/gnome-timezones-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
3 Active
2 Active
1 Inactive

Previous Reviews on this Version

masquerade-circus auto- active
JustPerfection posted a review
1. Remove try catch blocks in enable and disable. 2. Remove logs. Log should be only available in debug mode: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#no-excessive-logging 3. Replace line 375-378 with `Clock.settings = ExtensionUtils.getSettings()`: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js 4. Also do this in disable: ```js Clock.settings = null; Clock.button = null; ``` If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions