Review of "Toggle imwheel" version 4

Details Page Preview

This simple extension wants to mitigate the lack of a dedicated mouse wheel control on most of the modern linux distributions. Many are using imwheel as a temporary fix; however, if you are using a laptop, you might want to have two different settings for the touchpad and the mouse. This extension will add an icon in the top bar which lets you toggle imwheel between two custom settings. https://github.com/mijorus/toggle-imwheel


No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
8 Active
7 Rejected
6 Active
5 Rejected
4 Rejected
3 Rejected
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. You cannot create objects in global scope (line 6 utils.js) The only time you should create that gsettings object is in enable. To fix that use `setServiceMode(value)` instead of `setServiceMode(valueKey)`. 2. You forgot to null out `this.settings` in disable. You can also ping me on GNOME Matrix channel before sending the package here. I can review your extension in github. GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions
mijorus posted a review
sorry, my bad. you told me multiple times not to use objects in the global scope, should be fixed now