Review "Nano System Monitor" version 1

Review of "Nano System Monitor" version 1

Details Page Preview

Nano System Monitor

by eeeee

Show current status on GNOME Shell panel bar shows CPU|memory|swap usages,then the download|upload speed and CPU temperature and fan speed Different colors represent different percentage states and CPU temperature please use monospaced font for best experience

Extension Homepage: https://github.com/eeeeeio/gnome-shell-extension-nano-system-monitor

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
6	Active
5	Active
4	Active
3	Rejected
2	Active
1	Active

Previous Reviews on this Version

JustPerfection waiting for author April 30, 2022

Is this a correct upload? Because I see the uuid has been changed: https://extensions.gnome.org/review/31965

eeeee posted a review April 30, 2022

yes,I changed

JustPerfection active April 30, 2022

1. Move line 555-558 out of that if condition for the next version. 2. You are doing too much `new Settings.Prefs();` in prefs.js. Do dependency injection instead: ```js let prefs = new Settings.Prefs(); const widget = new NanoSystemMonitorPrefsWidget(prefs); ``` 3. Fix metadata URL. It is giving 404 error.

eeeee posted a review April 30, 2022

how can i get prefs in like function net_speed_enable_switch_changed

JustPerfection posted a review April 30, 2022

```js }, class NanoSystemMonitorPrefsWidget extends Gtk.Box { _init(prefs) { this._configuration = prefs; .... } net_speed_enable_switch_changed(widget) { this._configuration.IS_NET_SPEED_ENABLE.set(widget.get_active()); } ``` Now in ```js function buildPrefsWidget() { let prefs = new Settings.Prefs(); const widget = new NanoSystemMonitorPrefsWidget(prefs); // ... } ```