Review of "NordVPN Connect" version 19

Details Page Preview

Unofficial Gnome-Shell Extension to provide a GUI for the official NordVPN CLI Tool.

Extension Homepage
https://github.com/AlexPoilrouge/NordVPN-connect

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version Status
19 Rejected
18 Active
17 Rejected
16 Active
15 Active
14 Active
13 Inactive
12 Inactive
11 Inactive
10 Active
9 Active
8 Active
7 Active
6 Active
5 Inactive
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. Use initTranslations() and getSettings() from ExtensionUtils instead of creating your own custom functions: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js 2. Also do this on disable: ```js _indicator = null; SETTINGS = null; SubMenus = null; ``` 3. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html 4. You cannot create objects in global scope (prefs.js line 14). Move that line to `buildPrefsWidget` as local. You can pass it to `NVPN_Settings` as dependency injection. 5. Log should be only available in debug mode: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#no-excessive-logging 6. You cannot create objects in global scopes (line 28 subMenus.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions