Review of "Wallpaper Overlay" version 1

Details Page Preview

Extension to apply overlays on wallpaper Make sure imagemagick is installed. Features: * Option to choose primary colour of the overlay * Apply multiple overlays at once * You can use custom overlays (png or svg file) and apply it on your wallpaper * Option to auto-apply whenever the desktop wallpaper changes * Compatible with Wallpaper Switcher(gnome extension) so as to provide smooth experience * You can download more custom overlays from https://rishuinfinity.github.io/wallpaper-overlays-collection/

Extension Homepage
https://github.com/rishuinfinity/WallpaperOverlay

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
8 Active
7 Inactive
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please fix the schemas xml file name. 2. What's the reason for using `this` in line 81 (prefs.js)? It's not in a method. 3. You cannot create objects in global scope which is the same as init (line 19 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 4. Use ternary for line 114-116 (extension.js). 5. What's the reason for creating temp file (line 142-148 extension.js)? That's too much for init function. 6. You are using a Python script which is using two other dependencies. We are against scripts in other languages unless there is no other way: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#scripts-and-binaries You can use `ImageMagick` instead (also mention it in the description as dependency). And even the better way will be creating it with `St` and add it to the background: https://gjs-docs.gnome.org/st10~1.0_api/ If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
JustPerfection posted a review
btw, where do you use those svg files as resource?
rishuinfinity waiting for author
1. Done 2. No reason actually. I'd rename this to just Settings 3. Done 4. Done 5. The extension creates majorly 3 files: 1> The svg overlay with colour changed 2> The png version of the overlay 3> The modified wallpaper So, in order to keep these files separated from the rest of the code, I am using the folder temp. 6. I understand. I believe St would create some kind of image on top of the wallpaper and I thought this might be resource heavy, so I decided to create a new image with overlay applied on it and then set it as the wallpaper. Also I didn't actually understand how to use St to put a full screen image on top. I had first tried to do it using ImageMagick but was stuck on something, I'd give give another try. I'd update you with the next version soon If I make it through this time. 7. I am using those svg files to build the list of overlays in the prefs window. Question 1: I spent a lot of time reading documentations but I still couldn't find a proper way to change default height of the window. One way was to set "height_request" but it made the window scroll. Question 2: Do you know of any way so that I can know if the value of the DropDown has changed? I was first using TextComboBox which had a signal for that, but the comboBox had the issue that it didn't support scroll anymore. Thanks for your inputs.
JustPerfection posted a review
- For resizing the prefs window: https://gjs.guide/extensions/upgrading/gnome-shell-42.html#resize-preferences-window - Don't use `Gtk.ComboBox`. Use dropdown which is a new widget in GKT4: https://gjs-docs.gnome.org/gtk40~4.6.4-dropdown/ Or better, use `AdwComboRow`: https://gjs-docs.gnome.org/adw1~1.1.1-comborow/ You can read my extension if you need example for that: https://gitlab.gnome.org/jrahmatzadeh/just-perfection/-/blob/9d531147a832ffb8b92cbe2111e38a3b39d288c4/src/ui/adw/customize.ui#L114-117 btw, use proper adw widgets to wrap each of those widgets. I wrote a sample here that you can use: https://gjs.guide/extensions/upgrading/gnome-shell-42.html#fillpreferenceswindow
rishuinfinity posted a review
just writing this message to close this review.
JustPerfection rejected