Review of "Transmission Daemon Indicator" version 30

Details Page Preview

Monitor transmission-daemon or transmission-gtk.

Extension Homepage
https://github.com/thekevjames/gnome-shell-extension-transmission-daemon

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
30 Rejected
29 Active
28 Active
27 Active
26 Active
25 Active
24 Active
23 Active
22 Active
21 Active
20 Active
19 Active
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Rejected
4 Active
3 Rejected
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. Move line 29 (prefs.js) to `buildPrefsWidget` and make it local. Pass that to any function needed that instead of using it as global. 2. Remove all .po and .pot files: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files 3. Use initTranslations() and getSettings() from ExtensionUtils instead of creating your own custom functions (remove lib.js after that): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js 4. We don't have `3.40`. If you mean 40: https://gjs.guide/extensions/upgrading/gnome-shell-40.html 5. You cannot create objects in global scope which is the same as init (line 115 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization Move that line to enable and null that out in disable. 6. Move line 1644 (extension.js) to enable and null that out in disable. If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions