Review of "Put Windows" version 33

Details Page Preview

Fully customizable replacement for the old compiz put plugin. * Move windows to left/right side, bottom/top, center or corner (aka tile) * Move window to other screen * Select focused window using the keyboard * Application based window placement Please check github if your gnome-shell version is not supported

Extension Homepage
https://github.com/negesti/gnome-shell-extensions-negesti

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
34 Active
33 Inactive
32 Active
31 Inactive
30 Rejected
29 Active
28 Inactive
27 Inactive
26 Active
25 Inactive
24 Active
23 Inactive
22 Inactive
21 Active
20 Active
19 Active
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Rejected
9 Active
8 Active
7 Rejected
6 Inactive
5 Rejected
4 Inactive
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection active
Approved bu please fix these for the next version: 1. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html 2. No need to use ".0" for 4x versions. Only use "40", "41", "42". 3. Use initTranslations() and getSettings() from ExtensionUtils instead of creating your own custom functions (remove convenience.js after that): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js Supported on 3.36 and higher. 4. Why are you using `this` in line 1073, 1085 (extension.js)? 5. Also null out `_moveWindow` in disable (extension.js). 6. Remove .po and .pot files: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files 7. Also add schemas xml file to the `schemas` folder. 8. Please remove the duplicated code (line 366-406 utils.js). 9. Multi versioning is supported here, so you can remove 3x versions. If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
Nesta posted a review
Thanks for the super fast feedback !