Review of "Microphone Loopback" version 3

Details Page Preview

This extension enables hear microphone on headphones or speakers

Extension Homepage
https://github.com/atareao/microphone-loopback

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
5 Active
4 Rejected
3 Rejected
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. Please use correct schema ID. The Schema ID must use `org.gnome.shell.extensions` as a base ID. 2. Remove `stylesheet.css` since you are not using it: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files 3. 3.26 and 3.28 doesn't have `ExtensionUtils.getSettings()`. You can remove 3.x versions from metadata.json since multi versioning is supported here. 4. What's the reason to create custom notify function instead of using `Main.notify()`? 5. Unused var line 39 extension.js. 6. Also include schema's xml file in schemas folder. If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions