Review of "VLAN Switcher" version 3

Details Page Preview

Activate and deactivate VLAN connections from the system panel.

Extension Homepage
https://github.com/darcato/gnome-vlan-switcher

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

darcato auto- active
JustPerfection posted a review
1. Lang is a deprecated module. Please remove it for the next version (supported on 3.34 and higher): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html 2. Don't import gettext like that (line 11 extension.js). Do this instead: ```js const Gettext = imports.gettext.domain(Me.metadata['gettext-domain']); const _ = Gettext.gettext; ``` 3. Do `ExtensionUtils.initTranslations()` instead of line 188 (extension.js): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js 4. Also do this in disable: ```js vlanIndicator = null; ``` 5. Remove .po and .pot files: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions