Review of "Overview Navigation" version 18

Details Page Preview

This extension aims to make Gnome Shell easier to navigate using only the keyboard. It is inspired by the vim plugins of Firefox and Chrome.

Extension Homepage
https://github.com/nathanielsimard/overview-navigation

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
19 Active
18 Rejected
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Rejected
1 Inactive

Previous Reviews on this Version

JustPerfection waiting for author
Why are you doing that in line 169 prefs.js? and when line 76 to 112 happens in settings.js?
nathanielsimard posted a review
=== Why are you doing that in line 169 prefs.js? === Somehow PROPERTIES from the line `let { PROPERTIES } = Extension.imports.settings` is undefined even if declared as follow. ``` const PROPERTIES = { SHOW_OVERVIEW_WHEN_CHANGE_WORKSPACE_KEY: 'show-overview-when-change-workspace', SHOW_WINDOW_SELECTOR_WHEN_SHOW_OVERVIEW: 'show-window-selector-when-show-overview', LOGGING: 'logging', HINT_BACKGROUND_COLOR: 'background-color', HINT_CLOSING_FONT_COLOR: 'closing-font-color', HINT_FONT_COLOR: 'font-color', HINT_BORDER_COLOR: 'border-color', HINT_BORDER_SIZE: 'border-size' } ``` The weirdest part is that it becomes correctly defined after a second call to the method `buildPrefsWidget`. I would like to find another solution, but it seems to be the simplest one. === and when line 76 to 112 happens in settings.js? === This is some global variable defined in the code that I need to unit test the extension. Not optimal I agree, but usefull.
JustPerfection waiting for author
1. What happens if you do this in top of your code? ```js const { initialize, PROPERTIES } = Extension.imports.settings; ``` 2. Those extra codes in settings.js shouldn't be there. Create a helper function that adds those lines from test to the module (inside your test, not actual code).
nathanielsimard posted a review
Sorry for the looong response. 1. It doesn't fix the issue, the same behavior happens. 2. I agree, however the project is in maintenance mode and I built it with a compatiblity layer to run unit tests with node. There is a custom javascript transpiler to fix the imports and make them compatible with Gnome. I woudn't build it that way again, but hey we always learn :).
JustPerfection waiting for author
Did you use var instead of const for line 5 (settings.js)? `var` can be exported not `const` and `let`.
JustPerfection rejected
Newer version approved.