Review "Mutter Primary GPU" version 1 - GNOME Shell Extensions

Review of "Mutter Primary GPU" version 1

Details Page Preview

Mutter Primary GPU

by zaidka

Override primary GPU selection for Wayland

Extension Homepage: https://github.com/zaidka/mutter-primary-gpu

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version	Status
3	Active
2	Rejected
1	Rejected

Previous Reviews on this Version

JustPerfection rejected July 22, 2022

1. You are doing too much spawn commands (even `pkexec`). That's too much for session modes. Please remove session modes and send it again. 2. Also don't return in disable like that (line 34 extension.js). Do this instead: ```js if (sessionModeSignal) { sessionMode.disconnect(sessionModeSignal); sessionModeSignal = null; } if (indicator) { aggregateMenu._indicators.remove_child(indicator); indicator.menu.destroy(); indicator = null; } ```

zaidka posted a review July 22, 2022

Thanks for the feedback. I have made the requested changes and will upload again shortly.