Review of "Cloudflare 1.1.1.1 WARP Switcher" version 4

Details Page Preview

Unofficial Cloudflare 1.1.1.1 WARP Switcher extension for GNOME shell

Extension Homepage
https://github.com/Harshan01/Cloudflare-WARP-GNOME-Switcher

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
6 Active
5 Rejected
4 Rejected
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Use `ExtensionUtils.getSettings()` instead of creating your own custom functions (remove convenience.js after that): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js 2. Prefs isn't working on 42: ``` JS ERROR: Failed to open preferences: Error: Error invoking connect, at argument 1 (callback): Not an object _init@/home/ice/.local/share/gnome-shell/extensions/cloudflare-warp-gnome@harshan01/prefs.js:32:18 WARPSwitcherPrefsWidget@/home/ice/.local/share/gnome-shell/extensions/cloudflare-warp-gnome@harshan01/prefs.js:20:5 buildPrefsWidget@/home/ice/.local/share/gnome-shell/extensions/cloudflare-warp-gnome@harshan01/prefs.js:14:18 _init@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:32:44 ExtensionPrefsDialog@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:10:4 OpenExtensionPrefsAsync/<@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:129:33 asyncCallback@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:115:22 run@resource:///org/gnome/Shell/Extensions/js/dbusService.js:186:20 main@resource:///org/gnome/Shell/Extensions/js/main.js:22:13 run@resource:///org/gnome/gjs/modules/script/package.js:206:19 start@resource:///org/gnome/gjs/modules/script/package.js:190:8 @/usr/share/gnome-shell/org.gnome.Shell.Extensions:1:17 ``` You can read our GTK4 porting guide: https://gjs.guide/extensions/upgrading/gnome-shell-40.html#prefs GNOME 42 port guide: https://gjs.guide/extensions/upgrading/gnome-shell-42.html