Review of "MultiClock" version 9

Details Page Preview

A clock for showing a second timezone in the panel.

Extension Homepage
https://github.com/mibus/MultiClock

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
9 Rejected
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html 2. Only use 40. No need to use "40.0" and "40.1" in metadata.json. 3. Use initTranslations() and getSettings() from ExtensionUtils instead of creating your own custom functions (remove convenience.js after that): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js 4. Remove Makefile: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files 5. The constructor of the class that init returns shouldn't create objects (line 238 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization Move that line to enable and null that out in disable. 6. Log should be only available in debug mode: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#no-excessive-logging Logs like line 244 (extension.js) is really unnecessary. 7. Multi versioning is supported here. so if you want to drop 3.36 from metadata to have a cleaner code, you can do that. 8. Line 25 (extension.js) is unused. If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions