Review of "Walkpaper2" version 3

Details Page Preview

Set different wallpaper for each workspace by having the wallpaper switch on workspace change. Forked from the BlinkBP'project (https://github.com/BlinkBP/walkpaper) Unlike the previous extension is added a delay during transition. Is need for avoid flickering during switch using shortcuts :)

Extension Homepage
https://github.com/massimiliano-dalcero/walkpaper

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
7 Active
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Ok, fix the timeout and it can be approved. Anyway, 500 ms for a timeout with that callback is not a good idea and as I said monitoring changed signal is the way to go.
yattamax posted a review
Nope. #1 is needed. I don't have any time. sorry.
yattamax posted a review
if you notice at aline 102 in extension.js I alredy use a signal: wSwitchedSignalId = global.workspace_manager.connect('workspace-switched', _changeWallpaper); But is not enough to avoid flickering during slide transation: because switch is too fast when triggered via keyboard shortcut. => SO: is need to add a delay when signal call _changeWallpaper. unfortunately in js there is no "sleep" function, therefore one is obliged to use a timeout. That's All Folks! :)
JustPerfection posted a review
You should remove the timeout in disable. If you don't do that, the callback can get triggered after disable in lock screen and that's a security issue. As I mentioned before, you can see the sample code here: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources
yattamax posted a review
oookay. I not notice this you suggestion. Sorry. maybe I could have fixed it