Review of "IdeaPad Controls" version 6

Details Page Preview

Control Lenovo IdeaPad laptops options: Conservation Mode, Camera Lock, Fn Lock, Touchpad Lock, USB charging. Check Github page for password-less setup.

Extension Homepage
https://github.com/AzzamAlsharafi/ideapad-controls-gnome-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
14 Active
13 Rejected
12 Rejected
11 Rejected
10 Active
9 Active
8 Active
7 Active
6 Rejected
5 Active
4 Active
3 Rejected
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. You cannot create objects in global scope which is the same as init (line 18 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 2. Also null out `settings` in disable. 3. Don't call the function directly in global scope (line 68 extension.js). The best practice would be creating two modules for that, one for quick settings, other for aggregate menu. and import those modules based on shell version.