Review of "WebFeed" version 5

Details Page Preview

RSS and Atom Feed reader for GNOME Shell

Extension Homepage
https://github.com/xynium/webfeed

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
8 Active
7 Inactive
6 Active
5 Rejected
4 Active
3 Inactive
2 Rejected
1 Inactive

Previous Reviews on this Version

JustPerfection rejected
Don't create global variables in prefs file (feedstore, settings and widget2 in prefs.js). They won't get garbage collected after window close.
Xynium posted a review
Ok, so i have to change the whole structure of the prefs I send you an other zip JP
JustPerfection posted a review
Not the structure, just make them local in `buildPrefsWidget` and then pass them to the functions needing those.
Xynium posted a review
these function don't need the value they need the referance to those variables not sure javascript pass the pointer. I will make a class. JP