Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.
Version | Status |
---|---|
2 | Active |
1 | Rejected |
1. Please add GitHub or GitLab url to the metadata.json: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed 2. Please remove install.sh: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files 3. `Tweener` is a deprecated module. Please remove it for the next version. You can use `ease()` instead. For example: ```js widget.ease({ x: newX, y: 10, opacity: 100, duration: 2000, mode: Clutter.AnimationMode.EASE_OUT_BOUNCE, onComplete: () => { log('Animation is finished'); } }); ``` More about animation mode: https://gjs-docs.gnome.org/clutter10~10_api/clutter.animationmode 4. Remove timeout on disable (line 123 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 5. Also null out `button` in disable. 6. You are doing too much in init function (line 89 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
Hello team, Thank you for reviewing my extension. I have made all the changes you proposed' but not yet uploaded a fresh copy. My only outstanding issue is that I do not have a Github or Gitlab account, nor intend to create one. So are you suggesting that I will be unable to contribute an extension without such an account? In this is the case, then I shall not proceed, but thank you anyway. I was simply trying to help the community; and not having such an account seems counter-productive to me. If however I can leave the URL field blank, (per your item 1 above), then I shall proceed to upload my fresh copy. Please can you ping me a quick email to confirm how to proceed. Thanks again! Peter
Hi, you can still send the package without having git URL.
btw, you can also use GNOME's GitLab in case you prefer to have it in gnome.org: https://gitlab.gnome.org/
Hi Team, Please note that fresh version uploaded with your proposed changes. Thank you. Peter