Review of "Denon AVR controler" version 5

Details Page Preview

Denon AVR controler

Extension Homepage
https://framagit.org/sylter/denon-avr-controler

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
10 Active
9 Rejected
8 Active
7 Active
6 Active
5 Rejected
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. Please include the xml file for the schema: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#gsettings-schemas 2. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html 3. You cannot create objects in global scope which is the same as init (line 34 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 4. Also null out `denonAVRindicator` in disable. 5. no need to get gsettings object manually in `loadSettings` function (line 243 extension.js). Use `ExtensionUtils.getSettings()` instead: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions