Review of "Show External IP" version 9

Details Page Preview

Displays your external IP in the Toolbar and sends a system notification if changed. This extension is handy for those work at different locations or with different VPNs to quickly see your public IP and country. It uses the free thisipcan.cyou service to check at regular intervals and whenever computer network events occur (like switching networks or locations).

Extension Homepage
https://github.com/cwittenberg/thisipcan.cyou

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
15 Active
14 Inactive
13 Rejected
12 Rejected
11 Inactive
10 Rejected
9 Rejected
8 Rejected
7 Rejected
6 Rejected
5 Inactive
4 Inactive
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection waiting for author
Is this working? Because both `network_monitor` and `presence` get garbage collected at the end of enable function.
JustPerfection waiting for author
Also, you should disconnect those signals in disable.
cwittenberg posted a review
I can confirm it is working as expected, despite GC. I can disconnect/disable this in disable per your steer - but then I have no choice but to make these variables in global scope I'm afraid. Would it be a fair if I make the network monitor vars global, initialize them in Enable and disconnect them in Disable function?
JustPerfection rejected
You can make them global but initialize them in enable. then null them out in disable. Please send it with the fix.