Review of "Show External IP" version 9

Details Page Preview

Displays your external IP in the Toolbar, including Country flag, sends a system notification if IP changed. Shows also IP history with Export and an image of the approximate location. This extension is handy for those who work at different locations or with different VPNs to quickly see your public IP and country. Clipboard Access: Used to copy IP addresses, locations, and network details from the extension menu to your clipboard.

Extension Homepage
https://github.com/cwittenberg/thisipcan.cyou

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Previous Reviews on this Version

JustPerfection waiting for author
Is this working? Because both `network_monitor` and `presence` get garbage collected at the end of enable function.
JustPerfection waiting for author
Also, you should disconnect those signals in disable.
cwittenberg posted a review
I can confirm it is working as expected, despite GC. I can disconnect/disable this in disable per your steer - but then I have no choice but to make these variables in global scope I'm afraid. Would it be a fair if I make the network monitor vars global, initialize them in Enable and disconnect them in Disable function?
JustPerfection rejected
You can make them global but initialize them in enable. then null them out in disable. Please send it with the fix.