Review of "ExpressVPN - EVPN Shell Assistant ( express vpn )" version 2

Details Page Preview

Allows ExpressVPN to be controlled through the GNOME shell.

Extension Homepage
https://github.com/stuartjamesgilmour/evpn-assistant

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection waiting for author
This one can be approved but it's better to have the cleanup inside the same class: ```js var EvpnAssistMenu = GObject.registerClass( ... destroy() { Main.layoutManager.disconnect(this._startingUpSignal); this._startingUpSignal = undefined; if (this.pollHandle) { clearTimeout(evpnAssistantMenu.pollHandle); this.pollHandle = undefined; } super.destroy(); } ... ``` Do you want to fix it and send it again?
sgilmour posted a review
Thanks for the feedback, best to do things the correct way. This was the very first time I'd ever written anything in javascript, let alone an GNOME shell extension. I'll upload the revision shortly.
JustPerfection rejected
Newer version approved. Thanks!