Review of "Endless Desktop" version 1

Details Page Preview

Endless OS signature desktop

Extension Homepage
https://github.com/endlessm/eos-desktop-extension

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Is this the official account for endless os (Asking for trademark): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#copyrights-and-trademarks 2. You cannot create objects in the constructor of the class that init returns (line 35 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization Move that line to enable and null it out in disable. 3. You cannot create objects in global scope. Global scope is the same as init function (line 220 ui/layout.js). 4. Is there any reason for using `com.endlessm.desktop-extension` schema id instead of standard path for extensions? Please read about the schema id here: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#gsettings-schemas 5. Remove the timout on destroy (line 81 ui/panel.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
endlessos posted a review
Hello JustPerfection, thanks for your review! Please see replies to each of your points below: 1. Yes this is the official account for Endless OS. The human behind this submission is João Paulo Rechi Vita, and I am a lead software engineer at Endless OS Foundation. Let me know if any additional verification is required, and how to provide it. 2. Addressed in https://github.com/endlessm/eos-desktop-extension/pull/72. 3. Addressed in https://github.com/endlessm/eos-desktop-extension/pull/73 and https://github.com/endlessm/eos-desktop-extension/pull/74. 4. The reason for using `com.endlessm.desktop-extension` gsettings schema id is purely historical. When this code was first written, it was a series of patches to gnome-shell. When we split it off as an extension, we needed to migrate the icon-grid data from its original, "regular gnome-shell" state to the state that implements some of the extensions features (ex., gnome-software always on the end of the first page), and we needed a place to store the information that the migration had been run, so we added a gsetting using the namespace you see. While we could have chosen something under org.gnome.shell.extensions, we did not, unfortunately (IDK if that rule already existed in mid 2020), and now all Endless OS systems in the wild depend on that ID, so we can't change it (at least not on Endless OS). So if we could keep that ID, that would be nice -- please let me know if that is a possibility. 5. Addressed in https://github.com/endlessm/eos-desktop-extension/pull/72. Also, how do I upload an updated version of the extension with fixes for the review comments? Should I just create a new submission? Thanks again, JP (jprvita)
JustPerfection posted a review
Hi, - No more verification needed (also got the confirmation from Georges Stavracas). - We've added schema id to the review guidelines in 2022. No need to change the schema id though. Please send the next version just like the first version you've posted here. Thanks.