Review of "AVD applet" version 4

Details Page Preview

Provide menu to run android virtual devices

Extension Homepage
https://github.com/maxxx1313/applet-avd

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
4 Rejected
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

maxxx1313 auto- active
JustPerfection rejected
1. Remove the timeout on destroy or disable (line 65 and 193 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 2. Log should be only available in debug mode: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#no-excessive-logging 3. Also do this in disable: ```js applet = null; ``` 4. Remove try catch block in enable. We want fatal error in case the extension is doing something wrong. 5. Remove unnecessary `enabled` since it doesn't get read (line 19, 233, 242 extension.js). If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions