Review "Toggle workspace span" version 1

Review of "Toggle workspace span" version 1

Details Page Preview

Toggle workspace span

by arngo

Toggle workspaces spanning displays.

Extension Homepage: https://github.com/arngo/gnome-shell-extension-toggle-workspace-span

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
5	Active
4	Active
3	Active
2	Active
1	Rejected

Previous Reviews on this Version

JustPerfection rejected November 3, 2022

1. You cannot create objects in global scope which is the same as init (line 19 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization Move that to enable and null that out in disable. 2. Also do this in disable: ```js this.settings = null; ``` If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions

arngo posted a review November 3, 2022

I instead moved the settings and mutterSettings objects to inside the other classes, I hope that's fine. I've submitted a new version. Thanks.