Review of "TopIconsFix" version 14

Details Page Preview

Shows legacy tray icons on top – the fixed version of https://extensions.gnome.org/extension/495/topicons/


No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
22 Active
21 Active
20 Rejected
19 Active
18 Active
17 Inactive
16 Inactive
15 Inactive
14 Rejected
13 Active
12 Active
11 Active
10 Active
9 Rejected
8 Rejected
7 Rejected
6 Active
5 Inactive
4 Rejected
3 Rejected
2 Rejected
1 Active

Previous Reviews on this Version

aleskva auto- active
JustPerfection posted a review
1. Please add GitHub or GitLab url to the metadata.json: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed 2. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
JustPerfection rejected
and rejected because the timeout needs to be removed on disable (line 116 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources
aleskva posted a review
No problem, will fix code related issues soon. Just a question to the metadata related issue, is there a way to change the user/owner of the package? If I would link it to my GitHub, I would also have to change the username, under which it is uploaded, and also the the e-mail address and the user profile name (this is the only one I can change now). But I think there is no such way currently to change all of them, so I'm a bit stuck (Yes, I considered a reupload under new account, but no, I won't do that for convenience of the users of the extension. I also considered creating a new GitHub/Gitlab account only for this extension, but I don't like this solution either).
JustPerfection posted a review
If you want to change the EGO account info such as email and username you can open an issue here: https://gitlab.gnome.org/Infrastructure/extensions-web/-/issues/