Review of "Translate clipboard" version 18

Details Page Preview

Translate clipboard text

Extension Homepage
https://github.com/lsnow/translate-clipboard

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
23 Active
22 Active
21 Rejected
20 Rejected
19 Active
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Inactive
1 Active

Previous Reviews on this Version

JustPerfection waiting for author
What is `trans` file and what's the reason for not using gjs instead of bash? https://gjs.guide/extensions/review-guidelines/review-guidelines.html#scripts-and-binaries
JustPerfection waiting for author
Also remove line 5 (prefs.js)
voidyu posted a review
Sorry, it's taken over a year to respond. The `trans` script is taken from https://github.com/soimort/translate-shell What's the reason for not using gjs instead of bash? Because support multiple translation engines is a bit of annoying. If using gjs, i can only support google.
JustPerfection posted a review
Why not asking users to install it as a dependency and not shipping it in the extension package?
voidyu posted a review
Because I modified Google's URL and I want to replace it with gjs in the future, although I haven't started yet,I may rewrite it with gjs starting from gnome47.
JustPerfection active
Approved this for now base only on the diff but please move that script out of the extension package for the future updates if it's possible.