Review of "Noiseclapper - Soundcore Life for GNOME" version 1

Details Page Preview

Provides control of Soundcore Life Q30 Headphones (and others)

Extension Homepage
https://github.com/JordanViknar/Noiseclapper

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Use `ExtensionUtils.openPrefs()` instead. 2. Also do this in disable: ```js noiseclapperindicator = null; ``` 3. Also include schemas xml file: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#gsettings-schemas 4. You cannot create objects in init (line 13 prefs.js). Move that line to `settings`. You can attach it to the `box` if you want to avoid garbage collecting when the function ends. 5. What's the reason for not doing that Python script in gjs? https://gjs-docs.gnome.org/gio20~2.66p-socket/ Rules for Python scripts: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#scripts-and-binaries If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions