Review "Battery indicator (upower)" version 1

Review of "Battery indicator (upower)" version 1

Details Page Preview

Battery indicator (upower)

by malko

Display battery level indicators as reported by upower

Extension Homepage: https://github.com/malko/battery-indicator-upower

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
9	Active
8	Rejected
7	Active
6	Active
5	Active
4	Active
3	Rejected
2	Active
1	Inactive

Previous Reviews on this Version

JustPerfection active December 22, 2022

Instead of using the `destroy` output, null out the `settingsManager` after destroy (line 261 extension.js). If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions

malko posted a review December 22, 2022

@justPerfection, I've just inactivate this revision as I was a little to confident in the gnome-extension pack command, and some files where missing. Sorry for that ! settingsManager is in fact assigned null as the method destroy() effectively return null on purpose.