GNOME Shell Extensions

Review of "Tado°" version 3

Details Page Preview

Tado°

by bitwiseshift

Manages Tado° home heating. This extension is not affiliated, funded, or in any way associated with Tado

Extension Homepage
https://github.com/dmzoneill/tado-gnome-shell-extension
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
8 Active
7 Active
6 Active
5 Active
4 Rejected
3 Rejected
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Remove `Makefile`: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files 2. Why are you wrapping those classes by try catch block? - TadoAboutMenuStrategy.js - TadoBaseItem.js - TadoButtonListItem.js - TadoCustomSectionHeader.js - TadoHeader.js - TadoHelpers.js - TadoHyperlinkMenuItem.js - TadoLoginMenuStrategy.js - TadoMenuStrategy.js - TadoSignInMenuItem.js - TadoTextMenuItem.js - TadoZoneListItem.js - TadoZoneListItemSeparator.js
bitwiseshift posted a review
Hi, I was looking into solving a circular dependency issue. It can probably be removed, but no harm leaving it there either.