Review "Desktop Clock Legacy" version 1

Review of "Desktop Clock Legacy" version 1

Details Page Preview

Desktop Clock Legacy

Add a clock to the desktop ! Please use dconf-editor to change settings. This extension is a simple fork of the 'Desktop Clock' extension modified to work with Gnome Shell 3.36. This requires removal of the Settings dialog.

Extension Homepage: https://gitlab.com/andreasplesch/azclock_3.36

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
2	Active
1	Rejected

Previous Reviews on this Version

JustPerfection rejected January 17, 2023

1. You should remove the timeout on destroy (line 568 extension.js) https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 2. Please fix the indentations for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Reviewers note: This fork has the permission for using the original name in its name by the original author (GNOME Matrix Extensions room).

andreasplesch posted a review January 17, 2023

Thanks. Let me work with the main author on these concerns.