Review "Finans Monitörü" version 1 - GNOME Shell Extensions

Review of "Finans Monitörü" version 1

Details Page Preview

Finans Monitörü

by DoubleT

An Extension to track gold and foreign exchange prices in Turkey in real time with finans.truncgil.com API.

Extension Homepage: https://github.com/TaylanTatli/finansmonitoru

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
2	Active
1	Rejected

Previous Reviews on this Version

JustPerfection rejected February 5, 2023

1. Please remove unnecessary file (stylesheet.css): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files 2. Wrong schema path (should end with `finans-monitor`) 3. Use `ExtensionUtils.getSettings()` instead (line 18-27 prefs.js, line 52-63 extension.js). Remove `convenience.js` after that. 4. Remove unused import (line 9 prefs.js). 5. Also add English description to the description. 6. `Soup` is different version in 43 and (40-42). So it won't work in 40-42: https://gjs.guide/extensions/upgrading/gnome-shell-43.html#soup3 7. What's the reason for spoofing the user agent (line 99 extension.js)? If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions

TaylanTatli posted a review February 5, 2023

Thank you for review. I uploaded again, I hope it's ok now.