Review of "Mullvad Indicator" version 6

Details Page Preview

Mullvad connection status indicator

Extension Homepage
https://github.com/Pobega/gnome-shell-extension-mullvad-indicator

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
20 Active
19 Active
18 Active
17 Active
16 Active
15 Rejected
14 Active
13 Active
12 Rejected
11 Active
10 Active
9 Rejected
8 Active
7 Rejected
6 Rejected
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

Pobega posted a review
This is a pretty big change. This is mostly updating to Gnome 43 and changing a few things for review. Got some help from someone on Github and verified that it works on my machine as expected. I had a question from a previous review (of a fork) though; there was talk about destroying the `this._timeout` variable, what's the proper way to do that? I could submit another review with that change but the object doesn't appear to have a `.destroy()` method.
Pobega posted a review
Erm, I realize now that I accidentally submitted a zip with a broken version of prefs.js, feel free to reject this one.
JustPerfection rejected
JustPerfection posted a review
For timeout, you can add this to the `MullvadIndicator`: ```js destroy() { this._stop(); super.destroy(); } ```