Review "KeyMan" version 1 - GNOME Shell Extensions

Review of "KeyMan" version 1

Details Page Preview

KeyMan

Access passwords from the gnome keyring in a convenient way: Simply search for your password and copy it to clipboad by clicking it. After a certain amount of time it will be removed automatically (default is 5 seconds). As this only works if the keyrings are unlocked, this extension also provides easy access to lock/unlock keyrings.

Extension Homepage: https://github.com/dpoetzsch/keyman

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
24	Active
23	Active
22	Active
21	Rejected
20	Active
19	Active
18	Active
17	Active
16	Rejected
15	Active
14	Active
13	Active
12	Active
11	Active
10	Rejected
9	Active
8	Active
7	Active
6	Active
5	Active
4	Active
3	Active
2	Rejected
1	Rejected

Previous Reviews on this Version

Meng Zhuo waiting for author October 10, 2014

Disconnect signal bindings(i.e. "CollectionCreated") in disable/destroy function is mandatory.

dpoetzsch posted a review October 10, 2014

Hi, thanks for the review, I forgot about those 4 DBus signals. Version 3 fixes that. Am I correct in the assumption that signal connections for widget events like "key-press-event" or similar are removed when I destroy the widget? I could not find code that disconnects these signals in any other extension.

Meng Zhuo rejected October 11, 2014

No, the anonymous functions which are connected to events like "key-press-event" won't be GCed They just won't be triggered any more. Disconnect widget events are SUGGESTION, not mandatory, I just hope you can disconnect them in the future versions.