Seems it will fail if there's static workspaces on disabling the extension, since you will make all workspaces to _keepAlive = false. I think you should take into account the case where there was not dynamic workspaces when enabled the extension, and call set_fixed_workspaces(0) if the extension was in fact enabled on the enable() function. I am wrong? Did you test to enable and disable the extension on that case to make sure?

Hi csoriano, thank you for reviewing the extension. I think you make a good point. I hadn't thought of that scenario. I just tested it now. It seems that the "_keepAliveId = false" has no effect on the workspaces if the user set the workspaces to static in the Gnome Tweak Tool. From my understanding the _keepAliveId will be considered only when using dynamic workspaces. Here's what I tested: 1. I used Gnome Tweak tool to set my workspaces to dynamic. 2. I enabled the extension with 6 fixed workspaces. 3. I used Gnome Tweak Tool to set the workspaces to a STATIC 4 workspaces. (This completely overwrote my extension. I ended up getting 4 static workspaces, not 6.) 4. I disabled the extension. I still had my four static workspaces. NONE were removed. 5. I used Gnome Tweak Tool to set the workspaces to dynamic again. I was left with two workspaces. The one with my window on it, and a free one that was dynamically created. In fact I think that this behaviour is as it should be. "_keepAliveId" will keep DYNAMIC workspaces alive, but it has no effect on STATIC workspaces. So if the user disables the extension, no workspaces should be left with "_keepAliveId = true" except the very first one. Let me know what you think. I might be misunderstanding you. Thanks. P.S. I'll work on the extension this week, so that the user won't have to disable and re-enable it to make changes to the number of fixed workspaces.

You're right. _keepAlive doesn't affect static workspaces as you said, as a side effect of the early return at https://git.gnome.org/browse/gnome-shell/tree/js/ui/windowManager.js#n212 But yeah, I wasn't sure so I asked you if you tested it. Nipicks: you have some unused files: style-sheet.css Otherwise looks fine