1. You are doing too much in init function. Move those line to enable and revert back the changes on disable: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 2. Follow the `session-modes` rules or remove it from metadata.json: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#session-modes If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions

Hi, thank you for the review. I believe the users of the extension expect that they will be able to continue switching the language using the same alt+shift key combination also in the unlock screen. Does it violate any guideline?

You cannot monitoring the keys in unlock dialog. That will violate the rules. But why not using `['grp:alt_shift_toggle', 'lv3:ralt_switch']` for `/org/gnome/desktop/input-sources/xkb-options` instead?

Technically, the code monitors only the modifier keys by polling the get_pointer() global function, so security-wise, I didn't think it would really hurt. There's no way to get any meaningful keystrokes with this method. If doing so on the unlock dialog is a show-stopper, I'll remove it, but I really think users will be confused. As per your suggestion, I believe you're referring to the `gsettings set org.gnome.desktop.input-sources sources` command. In the README.md, I described the rational of the extension and the problems multi-lingual users are faced with when trying to change the language using the modifier keys, and why SUPER+SPACE doesn't work when controlling a remote desktop. Please see the README.md file here: https://github.com/arikw/rx-input-layout-switcher Awaiting your reply

We had a discussion about your extension in GNOME Matrix channel. Please remove the session modes for the packages you ship here. You can read our discussion in: https://matrix.to/#/#extensions:gnome.org